Ports "Adds a Chat Reliability Layer" #6594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
|
i'm fairly certain that this did not resolve the issue on tg tgstation/tgstation#54692 (comment) but i'm fine to port it for parity's sake |
cm13-github
added a commit
that referenced
this pull request
Jul 3, 2024
cm13-github
added a commit
that referenced
this pull request
Jul 3, 2024
cm13-github
added a commit
that referenced
this pull request
Jul 3, 2024
Closed
cm13-github
added a commit
that referenced
this pull request
Jul 4, 2024
|
Doesn't work sadly |
cm13-github
added a commit
that referenced
this pull request
Jul 5, 2024
3 tasks
This was referenced Jul 6, 2024
cm13-github
added a commit
that referenced
this pull request
Jul 6, 2024
3 tasks
This was referenced Jul 7, 2024
cm13-github
added a commit
that referenced
this pull request
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Credit to tgstation/tgstation#79479 and tgstation/tgstation#79819
Everyone knows that chat will just eat your messages now and then, isn't that annoying?
What if SSchat was smart enough to keep track of your messages and notice when you didn't get one?
Well, now it can!
Explain why it's good for the game
Chat messages poofing into the aether is bad, really bad.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 ZephyrTFA, san7890
add: Chat Reliability Layer
code: TGUI chat messages now track their sequence and will be resent if the client notices a discrepenency
/:cl: